From 68c8873370bb6860d19753ae7d969d0061a28a6a Mon Sep 17 00:00:00 2001 From: Krist Wongsuphasawat Date: Tue, 30 Oct 2018 22:22:48 -0700 Subject: [PATCH] Merge pull request #17 from apache-superset/kristw--readme Update readme and remove unnecessary items from package.json --- .../temporary_superset_ui/superset-ui/README.md | 11 +++++------ .../superset-ui/package.json | 1 + .../superset-ui-translation/package.json | 16 ---------------- 3 files changed, 6 insertions(+), 22 deletions(-) diff --git a/superset-frontend/temporary_superset_ui/superset-ui/README.md b/superset-frontend/temporary_superset_ui/superset-ui/README.md index da58f97a0bba9..e8db37556d96f 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/README.md +++ b/superset-frontend/temporary_superset_ui/superset-ui/README.md @@ -1,4 +1,4 @@ -# @superset-ui +# @superset-ui [![Build Status](https://img.shields.io/travis/com/apache-superset/superset-ui.svg?style=flat-square )](https://travis-ci.com/apache-superset/superset-ui) @@ -44,22 +44,21 @@ superset-ui/ ... ``` -For easiest development +### Installation 1. clone this repo -2. install the root npm modules including lerna and yarn -3. have lerna install package dependencies and manage the symlinking between packages for you +2. have lerna install package dependencies and manage the symlinking between packages for you ```sh git clone ...superset-ui && cd superset-ui npm install -lerna bootstrap +npm run bootstrap ``` ### Builds, linting, and testing Each package defines its own build config, linting, and testing. You can have lerna run commands -across all packages using the syntax `lerna exec test` from the root `@superset/monorepo` root +across all packages using the syntax `npm run test` (or `npm run test:watch` for watch mode) from the root `@superset/monorepo` root directory. ### Publishing diff --git a/superset-frontend/temporary_superset_ui/superset-ui/package.json b/superset-frontend/temporary_superset_ui/superset-ui/package.json index 0f09da012baef..da05d0c0685c9 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/package.json +++ b/superset-frontend/temporary_superset_ui/superset-ui/package.json @@ -4,6 +4,7 @@ "description": "Superset UI", "private": true, "scripts": { + "bootstrap": "lerna bootstrap", "build": "yarn run build:cjs && yarn run build:esm", "build:cjs": "NODE_ENV=production beemo babel ./src --out-dir lib/ --minify --workspaces=*", "build:esm": "NODE_ENV=production beemo babel ./src --out-dir esm/ --esm --minify --workspaces=*", diff --git a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-translation/package.json b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-translation/package.json index e02f083b85c7d..48900490eb5d5 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-translation/package.json +++ b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-translation/package.json @@ -25,27 +25,11 @@ }, "homepage": "https://github.com/apache-superset/superset-ui#readme", "devDependencies": { - "@data-ui/build-config": "^0.0.23", "jest-mock-console": "^0.4.0" }, "dependencies": { - "@babel/runtime": "^7.1.2", "jed": "^1.1.1" }, - "beemo": { - "module": "@data-ui/build-config", - "drivers": [ - "babel", - "eslint", - { - "driver": "jest", - "env": { - "NODE_ENV": "test" - } - }, - "prettier" - ] - }, "publishConfig": { "access": "public" }