From 9bd5718eae05107a92c3c91aba86760f643fe670 Mon Sep 17 00:00:00 2001 From: Kamil Gabryjelski Date: Thu, 4 Mar 2021 08:18:56 +0100 Subject: [PATCH] fix: rename DnD types to match component names in Superset (#988) --- .../src/shared-controls/dndControls.tsx | 4 ++-- .../packages/superset-ui-chart-controls/src/types.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx index 57de72c1950f1..30bb7d7b180ab 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx +++ b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx @@ -26,8 +26,8 @@ const timeColumnOption = { description: t('A reference to the [Time] configuration, taking granularity into account'), }; -export const dndGroupByControl: SharedControlConfig<'DndColumnSelectControl'> = { - type: 'DndColumnSelectControl', +export const dndGroupByControl: SharedControlConfig<'DndColumnSelect'> = { + type: 'DndColumnSelect', label: t('Group by'), default: [], description: t('One or many columns to group by'), diff --git a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/src/types.ts b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/src/types.ts index 0134c15eb6a89..47a20623f062d 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/src/types.ts +++ b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/src/types.ts @@ -139,7 +139,7 @@ export type InternalControlType = | 'MetricsControl' | 'AdhocFilterControl' | 'FilterBoxItemControl' - | 'DndColumnSelectControl' + | 'DndColumnSelect' | 'DndFilterSelect' | keyof SharedControlComponents; // expanded in `expandControlConfig`