diff --git a/.travis.yml b/.travis.yml index c19c14f9..34ce1802 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,10 +4,6 @@ node_js: - 8 - 10 -before_install: - - curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.6.0 - - export PATH="$HOME/.yarn/bin:$PATH" - script: - yarn run build - yarn run lint diff --git a/CONTRIBUTING-zh_CN.md b/CONTRIBUTING-zh_CN.md index 9841c993..4c3c8a7f 100644 --- a/CONTRIBUTING-zh_CN.md +++ b/CONTRIBUTING-zh_CN.md @@ -53,7 +53,8 @@ 6. 确保能通过 lint 校验。 ```sh - npm run lint:fix + npm run format + npm run lint ``` 7. 请确保能通过所有测试用例。 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 04299a66..4828116a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -53,7 +53,8 @@ _Before_ submitting a pull request, please make sure the following is done… 6) Ensure the linting is good via `yarn run lint:fix`. ```sh - npm run lint:fix + npm run format + npm run lint ``` 7) Ensure the testing is good via `yarn run test`. diff --git a/package.json b/package.json index 4e2199f3..b9143a8a 100644 --- a/package.json +++ b/package.json @@ -30,8 +30,8 @@ "zhihu-video-player" ], "scripts": { - "format": "prettier --write \"packages/**/*.{js,json,md}\" \"*.{js,json,md}\"", - "lint": "eslint --fix \"packages/**/*.js\" \"*.js\"", + "format": "prettier \"packages/**/*.{js,json,md}\" \"*.{js,json,md}\"", + "lint": "eslint \"packages/**/*.js\" \"*.js\"", "test": "jest", "test:coverage": "jest --coverage", "test:watch": "jest --watch --notify",