Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add defaultQuality prop #141

Merged
merged 2 commits into from
Sep 23, 2020
Merged

feat: add defaultQuality prop #141

merged 2 commits into from
Sep 23, 2020

Conversation

TaraLoveCats
Copy link
Contributor

Pull Request Template

Description

Add a optional prop defaultQuality to Griffith, which controls the default definition of a playing video.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Set a value hd to prop defaultQuality in PlayerContainer , and it works;
  • Code logic does not change when no defaultQuality is passed.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2020

Codecov Report

Merging #141 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   49.66%   49.63%   -0.03%     
==========================================
  Files         126      126              
  Lines        1800     1801       +1     
==========================================
  Hits          894      894              
- Misses        906      907       +1     
Impacted Files Coverage Δ
.../src/components/PlayerContainer/PlayerContainer.js 0.00% <0.00%> (ø)
...th/src/contexts/VideoSource/VideoSourceProvider.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8109f6...f6e1263. Read the comment docs.

@xiaoyuhen xiaoyuhen merged commit 084f2fa into zhihu:master Sep 23, 2020
@TaraLoveCats TaraLoveCats deleted the dev-q branch September 23, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants