Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some MSE error #26

Merged
merged 2 commits into from
Mar 25, 2019
Merged

fix: some MSE error #26

merged 2 commits into from
Mar 25, 2019

Conversation

xiaoyuhen
Copy link
Contributor

fix: some MSE error

Description

  • fix: mediaSource.endOfStream() Throws error
  • fix: SourceBuffer has been removed

@xiaoyuhen xiaoyuhen added the bug🐛 Something isn't working label Mar 25, 2019
@codecov-io
Copy link

codecov-io commented Mar 25, 2019

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   53.32%   53.32%           
=======================================
  Files         123      123           
  Lines        1652     1652           
=======================================
  Hits          881      881           
  Misses        771      771
Impacted Files Coverage Δ
packages/griffith-mp4/src/player.js 0% <0%> (ø) ⬆️
packages/griffith-mp4/src/mse/controller.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7df92e7...5423a4c. Read the comment docs.

@liuwuhaoo
Copy link
Contributor

LGTM

@xiaoyuhen xiaoyuhen merged commit 8f38191 into zhihu:master Mar 25, 2019
@xiaoyuhen xiaoyuhen deleted the mse branch April 2, 2019 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants