Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: source change & handler error #261

Merged
merged 5 commits into from
Mar 9, 2022
Merged

fix: source change & handler error #261

merged 5 commits into from
Mar 9, 2022

Conversation

shiyiya
Copy link
Contributor

@shiyiya shiyiya commented Mar 8, 2022

Pull Request Template

Description

  • 监听函数一直是旧的,状态更新后函数内 state 为旧值(如:example 里面的按钮功能无法工作)
  • source 修改时重置进度条

Fixes # (issue)

How Has This Been Tested?

  • run example

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

example/src/MP4Page.tsx Outdated Show resolved Hide resolved
@ambar ambar merged commit 9adcf32 into zhihu:master Mar 9, 2022
@shiyiya shiyiya deleted the patch-1 branch March 9, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants