fix: standalone build #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=======================================
Coverage 53.32% 53.32%
=======================================
Files 123 123
Lines 1652 1652
=======================================
Hits 881 881
Misses 771 771Continue to review full report at Codecov.
|
ambar
reviewed
Mar 26, 2019
| }, | ||
|
|
||
| dispose() { | ||
| ReactDOM.unmountComponentAtNode(target) |
There was a problem hiding this comment.
unmountComponentAtNode 是必须的，不然注册的定时器/事件之类的不能被清理（didMount/willUnmount 清理）。之前有提过这个。render 也重复了。
xiaoyuhen
added a commit
that referenced
this pull request
Mar 26, 2019
This reverts commit 359af25.
xiaoyuhen
added a commit
that referenced
this pull request
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: standalone build