Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add buffered cache #43

Merged
merged 2 commits into from
Mar 27, 2019
Merged

feat: add buffered cache #43

merged 2 commits into from
Mar 27, 2019

Conversation

xiaoyuhen
Copy link
Contributor

@xiaoyuhen xiaoyuhen commented Mar 27, 2019

feat: add buffered cache

Description

If the buffered has cache, we don't need to repeat request video data.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@xiaoyuhen xiaoyuhen added the enhancement✨ New feature or request label Mar 27, 2019
@codecov-io
Copy link

codecov-io commented Mar 27, 2019

Codecov Report

Merging #43 into master will decrease coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   53.27%   52.98%   -0.29%     
==========================================
  Files         123      123              
  Lines        1650     1659       +9     
==========================================
  Hits          879      879              
- Misses        771      780       +9
Impacted Files Coverage Δ
packages/griffith-mp4/src/mse/controller.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c5497c...9f5c966. Read the comment docs.

package.json Outdated Show resolved Hide resolved
@xiaoyuhen xiaoyuhen merged commit c7a7b2a into zhihu:master Mar 27, 2019
@xiaoyuhen xiaoyuhen mentioned this pull request Apr 2, 2019
@xiaoyuhen xiaoyuhen deleted the cache branch April 2, 2019 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants