Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cannot read property appendBuffer of undefined #48

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

xiaoyuhen
Copy link
Contributor

@xiaoyuhen xiaoyuhen commented Mar 28, 2019

fix: Cannot read property appendBuffer of undefined

Description

Fixes #47

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@xiaoyuhen xiaoyuhen added the bug🐛 Something isn't working label Mar 28, 2019
@codecov-io
Copy link

Codecov Report

Merging #48 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   52.98%   52.98%           
=======================================
  Files         123      123           
  Lines        1659     1659           
=======================================
  Hits          879      879           
  Misses        780      780
Impacted Files Coverage Δ
packages/griffith-mp4/src/mse/controller.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85de203...2824558. Read the comment docs.

@xiaoyuhen xiaoyuhen merged commit 9415b63 into zhihu:master Mar 28, 2019
@xiaoyuhen xiaoyuhen mentioned this pull request Apr 2, 2019
@xiaoyuhen xiaoyuhen deleted the buffer branch April 2, 2019 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'appendBuffer' of undefined
3 participants