Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replay case #60

Merged
merged 1 commit into from
Apr 9, 2019
Merged

fix: replay case #60

merged 1 commit into from
Apr 9, 2019

Conversation

xiaoyuhen
Copy link
Contributor

@xiaoyuhen xiaoyuhen commented Apr 9, 2019

fix: replay case

Description

the media source readState is ended when we click the replay button, so we cannot append new buffer to the media source.

The solution is we append an empty buffer to source buffer before we try click replay button or move the slider. Then the media source readState will reopen.
see https://github.com/servo/servo/blob/master/tests/wpt/web-platform-tests/media-source/mediasource-append-buffer.html#L144

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@xiaoyuhen xiaoyuhen added the bug🐛 Something isn't working label Apr 9, 2019
@xiaoyuhen xiaoyuhen merged commit e2693ad into zhihu:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants