Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache data #61

Merged
merged 1 commit into from
Apr 9, 2019
Merged

fix: cache data #61

merged 1 commit into from
Apr 9, 2019

Conversation

xiaoyuhen
Copy link
Contributor

fix: cache data

Description

use currentTime to confirm if we dont need to request video data

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@xiaoyuhen xiaoyuhen added the bug🐛 Something isn't working label Apr 9, 2019
@codecov-io
Copy link

codecov-io commented Apr 9, 2019

Codecov Report

Merging #61 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   52.08%   52.11%   +0.03%     
==========================================
  Files         123      123              
  Lines        1703     1702       -1     
==========================================
  Hits          887      887              
+ Misses        816      815       -1
Impacted Files Coverage Δ
packages/griffith-mp4/src/mse/controller.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2693ad...a310099. Read the comment docs.

@xiaoyuhen xiaoyuhen merged commit 0b5e874 into zhihu:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants