Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove mseUpdating flag #63

Merged
merged 1 commit into from
Apr 10, 2019
Merged

fix: remove mseUpdating flag #63

merged 1 commit into from
Apr 10, 2019

Conversation

xiaoyuhen
Copy link
Contributor

@xiaoyuhen xiaoyuhen commented Apr 10, 2019

fix: remove mseUpdating flag

Description

No need to use mseUpdating flag

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@xiaoyuhen xiaoyuhen added the bug🐛 Something isn't working label Apr 10, 2019
@codecov-io
Copy link

codecov-io commented Apr 10, 2019

Codecov Report

Merging #63 into master will increase coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   52.02%   52.08%   +0.06%     
==========================================
  Files         123      123              
  Lines        1705     1703       -2     
==========================================
  Hits          887      887              
+ Misses        818      816       -2
Impacted Files Coverage Δ
packages/griffith-mp4/src/mse/controller.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a0e079...9a72d97. Read the comment docs.

@xiaoyuhen xiaoyuhen merged commit 93867af into master Apr 10, 2019
@xiaoyuhen xiaoyuhen deleted the mse-updating branch April 11, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants