Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust video quality #65

Merged
merged 2 commits into from
Apr 11, 2019
Merged

feat: adjust video quality #65

merged 2 commits into from
Apr 11, 2019

Conversation

xiaoyuhen
Copy link
Contributor

@xiaoyuhen xiaoyuhen commented Apr 11, 2019

feat: adjust video quality

Description

we don't need to create a new MediaSource when the user switches video quality.

we remove the old buffer and append new video data When the user switches video quality.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@xiaoyuhen xiaoyuhen added the enhancement✨ New feature or request label Apr 11, 2019
@codecov-io
Copy link

codecov-io commented Apr 11, 2019

Codecov Report

Merging #65 into master will decrease coverage by 0.42%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   52.08%   51.65%   -0.43%     
==========================================
  Files         123      123              
  Lines        1703     1717      +14     
==========================================
  Hits          887      887              
- Misses        816      830      +14
Impacted Files Coverage Δ
packages/griffith-mp4/src/player.js 0% <0%> (ø) ⬆️
packages/griffith-mp4/src/mse/controller.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93867af...9e0cd22. Read the comment docs.

@xiaoyuhen xiaoyuhen merged commit f34077c into zhihu:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants