Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: end of stream when last GOP is played #83

Merged
merged 1 commit into from
Apr 19, 2019
Merged

fix: end of stream when last GOP is played #83

merged 1 commit into from
Apr 19, 2019

Conversation

xiaoyuhen
Copy link
Contributor

@xiaoyuhen xiaoyuhen commented Apr 19, 2019

fix: end of the stream when last GOP is played

Description

if we end of steam when the last GOP is not playing, the video duration will be changed, and the last GOP will not play ever.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@xiaoyuhen xiaoyuhen added the bug🐛 Something isn't working label Apr 19, 2019
@codecov-io
Copy link

codecov-io commented Apr 19, 2019

Codecov Report

Merging #83 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   50.59%   50.59%           
=======================================
  Files         124      124           
  Lines        1753     1753           
=======================================
  Hits          887      887           
  Misses        866      866
Impacted Files Coverage Δ
packages/griffith-mp4/src/mse/controller.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19d0dfc...3b17874. Read the comment docs.

@xiaoyuhen xiaoyuhen merged commit 1aaf240 into master Apr 19, 2019
@xiaoyuhen xiaoyuhen deleted the end branch April 19, 2019 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants