Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make a fake GOP when video dont have B/P frame #85

Merged
merged 1 commit into from
Apr 22, 2019

Conversation

xiaoyuhen
Copy link
Contributor

@xiaoyuhen xiaoyuhen commented Apr 22, 2019

fix: make a fake GOP when video dont have B/P frame

Description

some video don't have B/P frame, we should make a fake GOP, then we can play it with streaming
image

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • this video can play normally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@xiaoyuhen xiaoyuhen added the bug🐛 Something isn't working label Apr 22, 2019
@codecov-io
Copy link

codecov-io commented Apr 22, 2019

Codecov Report

Merging #85 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   50.59%   50.76%   +0.16%     
==========================================
  Files         124      124              
  Lines        1753     1759       +6     
==========================================
+ Hits          887      893       +6     
  Misses        866      866
Impacted Files Coverage Δ
...s/griffith-mp4/src/mp4/utils/getSamplesInterval.js 95.52% <100%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcd054a...d5d24b7. Read the comment docs.

@xiaoyuhen xiaoyuhen merged commit 116c19a into zhihu:master Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants