Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show better icon in dark theme #26

Open
zieren opened this issue Dec 3, 2022 · 1 comment
Open

Show better icon in dark theme #26

zieren opened this issue Dec 3, 2022 · 1 comment
Labels
bug Something isn't working p1 impacts normal use

Comments

@zieren
Copy link
Owner

zieren commented Dec 3, 2022

The FF dark theme modifies the icon's colors. Unfortunately black becomes white, but white remains white. I don't know if that is simply a bug or caused by the specific icon; I don't know any other page action extensions.

This means that the icon is just a white blob and the on/off versions are hard to tell apart. It looks like this is a common problem.

@zieren zieren added bug Something isn't working p1 impacts normal use labels Dec 3, 2022
@zieren
Copy link
Owner Author

zieren commented Dec 3, 2022

It might make sense to change the extension from a page_action to a browser_action. That's technically incorrect because it is page-specific, but page_action seems to be poorly supported (this issue being one case in point; another one being usability).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p1 impacts normal use
Projects
None yet
Development

No branches or pull requests

1 participant