Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase test coverage of std.crypto.tls #14174

Open
Tracked by #14178
andrewrk opened this issue Jan 3, 2023 · 1 comment
Open
Tracked by #14178

increase test coverage of std.crypto.tls #14174

andrewrk opened this issue Jan 3, 2023 · 1 comment
Labels
bug Observed behavior contradicts documented or intended behavior standard library This issue involves writing Zig code for the standard library.
Milestone

Comments

@andrewrk
Copy link
Member

andrewrk commented Jan 3, 2023

Extracted from #13980.

After implementing #14171, let's look at a test coverage report and decide what to do from there.

Marking as "bug". Guilty until proven innocent.

@andrewrk andrewrk added bug Observed behavior contradicts documented or intended behavior standard library This issue involves writing Zig code for the standard library. labels Jan 3, 2023
@andrewrk andrewrk added this to the 0.11.0 milestone Jan 3, 2023
@andrewrk andrewrk modified the milestones: 0.11.0, 0.12.0 Jun 19, 2023
@clickingbuttons
Copy link
Contributor

clickingbuttons commented Feb 27, 2024

Just want to give a heads up that I'm adding struct types from RFC 8446 and encoders /decoders for them in an effort to solve #15590, #15226, and #14573.

@andrewrk Why does tls.Client.readvAdvanced read more than a single TLS message? The signature states that returning 0 bytes does not mean EOF (like when receiving a non-application data message). I think it could be greatly simplified to read a single message and store the leftovers in a single cleartext_buffer instead of needing many temporary buffers that are causing buggy behavior.

Edit: It's because of the TLS record layer which may send fragmented plaintext handshake messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Observed behavior contradicts documented or intended behavior standard library This issue involves writing Zig code for the standard library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants