Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make std.url / std.uri more complete and RFC-compliant #14176

Closed
Tracked by #14178
andrewrk opened this issue Jan 3, 2023 · 4 comments
Closed
Tracked by #14178

make std.url / std.uri more complete and RFC-compliant #14176

andrewrk opened this issue Jan 3, 2023 · 4 comments
Labels
bug Observed behavior contradicts documented or intended behavior contributor friendly This issue is limited in scope and/or knowledge of Zig internals. enhancement Solving this issue will likely involve adding new logic or components to the codebase. standard library This issue involves writing Zig code for the standard library.
Milestone
0.11.0

Comments

@andrewrk
Copy link
Member

andrewrk commented Jan 3, 2023

zig/lib/std/Url.zig

Lines 6 to 8 in c9ef277

/// TODO: redo this implementation according to RFC 1738. This code is only a
/// placeholder for now.
pub fn parse(s: []const u8) !Url {

upstreaming @MasterQ32's zig-uri has been suggested
@andrewrk andrewrk added bug Observed behavior contradicts documented or intended behavior enhancement Solving this issue will likely involve adding new logic or components to the codebase. contributor friendly This issue is limited in scope and/or knowledge of Zig internals. standard library This issue involves writing Zig code for the standard library. labels Jan 3, 2023
@andrewrk andrewrk added this to the 0.11.0 milestone Jan 3, 2023
This was referenced Jan 3, 2023
Merged
Open
@ikskuh
Copy link
Contributor

ikskuh commented Jan 3, 2023

upstreaming @MasterQ32's zig-uri has been suggested

I obviously agree on that. zig-uri is well tested in several projects and has quite some unit tests as well. It should be fully spec compliant, as i've built it step-by-step from RFC3986.

@andrewrk
Copy link
Member Author

andrewrk commented Jan 3, 2023 •
edited
Loading

Alright, good sir, I have cleared the runway for you to upstream the project by merging some of your PRs that have been patiently waiting for a long time.

@ikskuh ikskuh mentioned this issue Jan 5, 2023
Merged
@ikskuh
Copy link
Contributor

ikskuh commented Jan 8, 2023

I guess this can be closed.

@andrewrk
Copy link
Member Author

andrewrk commented Jan 8, 2023

Landed in 87b2234

@andrewrk andrewrk closed this as completed Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Observed behavior contradicts documented or intended behavior contributor friendly This issue is limited in scope and/or knowledge of Zig internals. enhancement Solving this issue will likely involve adding new logic or components to the codebase. standard library This issue involves writing Zig code for the standard library.
Projects
None yet
Milestone
0.11.0
Development

No branches or pull requests
2 participants
@andrewrk @ikskuh