-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std.Thread: Mutex and Condition improvements #11497
Conversation
Is this a problem with stage2 inline assembly? If so, I can work on this to unblock you asap. However if it's possible to work around this with non-assembly code, you can check for |
@andrewrk Seems like stage2 either doesn't properly lower the Also, the CI also says |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I can't really comment on the platform specific implementations, but the FutexImpl
s seem fine. Also, the Condition
tests are quite good and can be reused for Semaphore
when the time comes to update those.
Just some really minor typos/comments:
Main Goals
Side Goals
u64
large sync primitives (if Futex is removed in the future, they can always be madeusize
large).std.Thread.Futex.Deadline
for accurately waiting on a Futex in a loop with a relative timeout.