p256: properly handle neutral element & add AffineCoordinates struct #8718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of multiple references to an anonymous structure to represent affine coordinates, add an actual `AffineCoordinates` structure. Also properly handle the neutral element during coordinate conversion and fix mixed addition. And comptime the small precomputation table for basepoint multiplication.
Mouvedia
reviewed
May 8, 2021
| @@ -49,21 +49,26 @@ pub const P256 = struct { | |||
| } | |||
|
|
|||
| /// Create a point from affine coordinates after checking that they match the curve equation. | |||
| pub fn fromAffineCoordinates(x: Fe, y: Fe) EncodingError!P256 { | |||
| pub fn fromAffineCoordinates(p: AffineCoordinates) EncodingError!P256 { | |||
There was a problem hiding this comment.
FYI
this should not really be considered breaking because p256.zig was added very recently (#8627)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of multiple references to an anonymous structure to represent affine coordinates, add an actual
AffineCoordinatesstructure.Also properly handle the neutral element during coordinate conversion and fix mixed addition.
And comptime the small precomputation table for basepoint multiplication.