-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework OnOff output cluster handler logic #145
Comments
Any sort of virtual clusters need to go, in my opinion. They were created to re-use the existing cluster handlers to create entities. With the ZHA library allowing direct entity creation, we need to start replacing virtual clusters with those. |
In this case it's not virtual clusters, it's a virtual entity linked to a handler. The clusters are real here. |
The attributes on the cluster is virtual thou. |
It doesn't make sense to convert a binary sensor for open/close or motion/no_motion to an event entity IMO. The logic regarding Other than that, it's similar to We should, however, consider implementing event entities for remotes with device automation triggers provided by quirks. |
Currently there is a special logic at
zha/zha/application/discovery.py
Line 449 in 9fe8345
I assume this logic stems from before we had event entities in home assistant and was some type of attempt to create a binary_input like entity from an OnOff client cluster.
We should add support for event entities for output clusters, and drop this rather confusing special logic for OnOff clusters.
The text was updated successfully, but these errors were encountered: