-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this plugin still needed ? #81
Comments
I also wonder the same thing. I use |
Just to make a comment on this, even though Chrome and Safari are now supporting onClick (tested it works at least on Safari ) there must be plenty of end user devices that cannot be or won't be updated to latest version or the respective mobile browsers. A Little bit like the IE issues on web development world. |
Any news? |
Waiting for official response. |
The TapEventPlugin in the React code base is not officially supported and is not enabled by default. Some browsers fixed the issue be cancelling the 300ms delay when building a web app, but not all users are able to upgrade. So yes, when you want the same touch/click functionality with the latest React, you'll still need this plugin. |
Clarified the need for this plugin a bit more in the README. Thanks. |
I wonder whether I should use
onClick
oronTouchTap
?The README mentions PRs and issues which are closed/merged.
React code seems to handle it natively: https://github.com/facebook/react/blob/54cbe2926249b0d8c1da17b6ecb19484cc409df1/src/renderers/dom/client/eventPlugins/TapEventPlugin.js#L143
Others say Apple fixed it on his side: https://www.reddit.com/r/reactjs/comments/4pe61k/why_do_we_need_reacttapeventplugin_in_our_projects/
So, is this plugin still needed if using latest React ? Should we use
onClick
oronTouchTap
?Could the README be updated with latest infos on this regard ?
The text was updated successfully, but these errors were encountered: