Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this plugin still needed ? #81

Closed
Offirmo opened this issue Sep 22, 2016 · 6 comments
Closed

Is this plugin still needed ? #81

Offirmo opened this issue Sep 22, 2016 · 6 comments

Comments

@Offirmo
Copy link

Offirmo commented Sep 22, 2016

I wonder whether I should use onClick or onTouchTap ?

The README mentions PRs and issues which are closed/merged.

React code seems to handle it natively: https://github.com/facebook/react/blob/54cbe2926249b0d8c1da17b6ecb19484cc409df1/src/renderers/dom/client/eventPlugins/TapEventPlugin.js#L143

Others say Apple fixed it on his side: https://www.reddit.com/r/reactjs/comments/4pe61k/why_do_we_need_reacttapeventplugin_in_our_projects/

So, is this plugin still needed if using latest React ? Should we use onClick or onTouchTap ?

Could the README be updated with latest infos on this regard ?

@pudgereyem
Copy link

I also wonder the same thing. I use onClick and it works fine in mobile Safari.
However, when the same website is bundles with Cordova, it still have the 300ms delay.

@HintikkaKimmo
Copy link

Just to make a comment on this, even though Chrome and Safari are now supporting onClick (tested it works at least on Safari ) there must be plenty of end user devices that cannot be or won't be updated to latest version or the respective mobile browsers. A Little bit like the IE issues on web development world.

@mahnunchik
Copy link

Any news?

@despire1119
Copy link

Waiting for official response.

@s0meone
Copy link

s0meone commented Nov 16, 2016

The TapEventPlugin in the React code base is not officially supported and is not enabled by default. Some browsers fixed the issue be cancelling the 300ms delay when building a web app, but not all users are able to upgrade.

So yes, when you want the same touch/click functionality with the latest React, you'll still need this plugin.

@s0meone
Copy link

s0meone commented Nov 16, 2016

Clarified the need for this plugin a bit more in the README.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants