Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ocfl-object specification version aware #108

Closed
zimeon opened this issue Mar 7, 2023 · 0 comments · Fixed by #109
Closed

Make ocfl-object specification version aware #108

zimeon opened this issue Mar 7, 2023 · 0 comments · Fixed by #109

Comments

@zimeon
Copy link
Owner

zimeon commented Mar 7, 2023

The current version of ocfl/object.py is hard-coded to version 1.0, e.g.:

ocfl-py> ./ocfl-object.py --show --objdir fixtures/1.1/good-objects/spec-ex-full
WARNING:ocfl.object:OCFL v1.1 Object at fixtures/1.1/good-objects/spec-ex-full has VALID STRUCTURE (DIGESTS NOT CHECKED)
WARNING:ocfl.object:Object tree
[fixtures/1.1/good-objects/spec-ex-full]
├── 0=ocfl_object_1.1 <--- ???
├── inventory.json 
├── inventory.json.sha512 
├── v1 
│   ├── content (3 files)
│   ├── inventory.json 
│   └── inventory.json.sha512 
├── v2 
│   ├── content (1 files)
│   ├── inventory.json 
│   └── inventory.json.sha512 
└── v3 
    ├── inventory.json 
    └── inventory.json.sha512 

The ??? is because the code is looking for a v1.0 declaration even though the validator is aware that it is a v1.1 object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant