Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit HttpInterceptorRequest#clone and HttpInterceptorResponse#clone #325

Closed
diego-aquino opened this issue Aug 15, 2024 · 1 comment · Fixed by #335
Closed

Omit HttpInterceptorRequest#clone and HttpInterceptorResponse#clone #325

diego-aquino opened this issue Aug 15, 2024 · 1 comment · Fixed by #335
Assignees
@diego-aquino
Labels
bug Something isn't working
Milestone
v0.9.0

Comments

@diego-aquino
Copy link
Member

diego-aquino commented Aug 15, 2024 •
edited
Loading

HttpInterceptorRequest#clone and HttpInterceptorResponse#clone are available because they inherit the native Request and Response classes. However, clone will not work on those objects and should not be exposed in our public API. To clone the request or response, users can use HttpInterceptorRequest#raw#clone and HttpInterceptorResponse#raw#clone.
@diego-aquino diego-aquino converted this from a draft issue Aug 15, 2024
@diego-aquino diego-aquino added the bug Something isn't working label Aug 15, 2024
@diego-aquino diego-aquino self-assigned this Aug 15, 2024
@diego-aquino diego-aquino added this to the v0.9.0 milestone Aug 15, 2024
@diego-aquino diego-aquino mentioned this issue Aug 20, 2024
Merged
@diego-aquino diego-aquino moved this from To do to In review in Zimic Aug 20, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Zimic Aug 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Released in v0.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diego-aquino diego-aquino

Labels
bug Something isn't working
Projects
Zimic
Status: Done
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

fix(#zimic): omit clone from intercepted requests and responses (#325) zimicjs/zimic
1 participant
@diego-aquino