Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isNewScreenshot to Comparison Results #83

Open
emilyrohrbough opened this issue Aug 2, 2018 · 1 comment · May be fixed by #103
Open

Add isNewScreenshot to Comparison Results #83

emilyrohrbough opened this issue Aug 2, 2018 · 1 comment · May be fixed by #103

Comments

@emilyrohrbough
Copy link

Often times new screenshots are not generated locally and checked in. This is not caught because our Travis CI builds create new reference screenshots are generated with no indication in the comparison results. It would be helpful to check if for a isNewScreenshot result boolean to assert all screenshots have been properly generated.
@emilyrohrbough
Copy link
Author

The BaseCompare would need changed here

The LocaleCompare would need changes in these places:

  1. When new
  2. When exists here and here

webOS101 pushed a commit to webOS101/wdio-visual-regression-service that referenced this issue Oct 14, 2019
Add isNewScreenshot to results
85be033 
Fixes zinserjan#83
@webOS101 webOS101 linked a pull request Oct 14, 2019 that will close this issue
Open
@emilyrohrbough emilyrohrbough mentioned this issue Jul 6, 2020
Open
@emilyrohrbough emilyrohrbough mentioned this issue Sep 10, 2020
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add isNewScreenshot to results webOS101/wdio-visual-regression-service
1 participant
@emilyrohrbough