Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Fix ZStream From Pull Implementation #299

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Fix ZStream From Pull Implementation #299

merged 1 commit into from
Dec 23, 2021

Conversation

adamgfraser
Copy link
Contributor

No description provided.

@runtologist
Copy link
Collaborator

Do I understand correctly that fromPull is only needed temporarily until the fix lands in ZIO streams?

@adamgfraser
Copy link
Contributor Author

Correct. I just inlined the code from the latest version of the series/2.x branch so once we do the next release we can delete it.

runtologist
runtologist approved these changes Dec 23, 2021
View reviewed changes
Copy link
Collaborator

@runtologist runtologist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for fixing this in ZIO streams.

@adamgfraser adamgfraser merged commit ecf6305 into zio-archive:series/2.x Dec 23, 2021
@adamgfraser adamgfraser deleted the frompull branch December 23, 2021 09:17
@adamgfraser
Copy link
Contributor Author

You want to do a release?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@runtologist runtologist runtologist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamgfraser @runtologist