Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket architectural & feature improvements #1528

Closed
jdegoes opened this issue Sep 19, 2022 · 1 comment
Closed

WebSocket architectural & feature improvements #1528

jdegoes opened this issue Sep 19, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@jdegoes
Copy link
Member

jdegoes commented Sep 19, 2022

Is your feature request related to a problem? Please describe.

Ideally WebSockets would be more thoroughly integrated into ZIO HTTP, with a more comprehensive feature set (e.g. sending a message to a client before receiving one), and with fewer data types in ZIO HTTP.

Describe the solution you'd like

Unknown.

Describe alternatives you've considered

None.

@jdegoes jdegoes added the enhancement New feature or request label Sep 19, 2022
@tusharmath
Copy link
Collaborator

tusharmath commented Sep 20, 2022

The current API allows sending a message without waiting for one from the client (collect on handshake event).
ChannelEvents are a bit complex, but can give a lot of performance gains while doing broadcasts.
I agree it's not the most elegant though. I think we can enhance it by attaching a middleware.

@jdegoes jdegoes closed this as completed Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants