Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for Request #652

Closed
dinojohn opened this issue Dec 16, 2021 · 3 comments · Fixed by #926
Closed

Update documentation for Request #652

dinojohn opened this issue Dec 16, 2021 · 3 comments · Fixed by #926
Assignees
@ShrutiVerma97
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers maintenance Chore or Maintenance tasks

Comments

@dinojohn
Copy link
Contributor

What is not easy to do right now?
The doc is outdated in https://github.com/dream11/zio-http/blob/main/docs/index.md#accessing-the-request

Describe the solution you'd like
Update the code snippets as per RC18

Why is it important?
Docs and examples help developers understand how to use zhttp.
@dinojohn dinojohn added documentation Improvements or additions to documentation maintenance Chore or Maintenance tasks labels Dec 16, 2021
@tusharmath tusharmath added the good first issue Good for newcomers label Dec 16, 2021
@Vipul-J
Copy link

Vipul-J commented Dec 16, 2021

Shall I work on this?

@amitksingh1490
Copy link
Collaborator

Sure go ahead

@tusharmath tusharmath changed the title Update documentation Update documentation for Request Dec 27, 2021
@ShrutiVerma97
Copy link
Contributor

#926

@amitksingh1490 amitksingh1490 linked a pull request Feb 4, 2022 that will close this issue
Documentation: Request #926
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShrutiVerma97 ShrutiVerma97

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers maintenance Chore or Maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Documentation: Request zio/zio-http
5 participants
@tusharmath @amitksingh1490 @ShrutiVerma97 @dinojohn @Vipul-J