Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Http.collectManaged #866

Closed
tusharmath opened this issue Jan 20, 2022 · 3 comments
Closed

add Http.collectManaged #866

tusharmath opened this issue Jan 20, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tusharmath
Copy link
Collaborator

Describe the solution you'd like
This should be possible

Http.collectManaged[Request] {
 case GET -> !! / "users" => ZManaged.succeed(Response.ok)
}
@tusharmath tusharmath added enhancement New feature or request good first issue Good for newcomers labels Jan 20, 2022
@beem812
Copy link
Contributor

beem812 commented Jan 26, 2022

I think I may be able to take this one, I have something that appears to work but I'm fairly new to the ZIO world. If I can take this one my first question is going to be: Is it appropriate to call useNow on the ZManaged to get a ZIO here?

@beem812
Copy link
Contributor

beem812 commented Jan 28, 2022

I forgot to link to this issue with my PR but I believe this is closed with #909

@girdharshubham
Copy link
Member

Thanks for this contribution @beem812. Also, congratulations on your first contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants