Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Version type to encode HttpVersion #954

Closed
tusharmath opened this issue Feb 4, 2022 · 1 comment · Fixed by #965
Closed

Create Version type to encode HttpVersion #954

tusharmath opened this issue Feb 4, 2022 · 1 comment · Fixed by #965
Assignees
@girdharshubham
Labels
enhancement New feature or request

Comments

@tusharmath
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
We should be able to specify Version via ClientRequest. This is currently supported only via HttpVersion

Describe the solution you'd like
A sum type should be created for Version with Http_1_1 and Http_1_2 and Http_2 as it's specialized types.
@tusharmath tusharmath added the enhancement New feature or request label Feb 4, 2022
@girdharshubham girdharshubham self-assigned this Feb 4, 2022
@girdharshubham
Copy link
Member

I'll take it on.

@tusharmath tusharmath mentioned this issue Feb 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@girdharshubham girdharshubham

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: add Version zio/zio-http
2 participants
@tusharmath @girdharshubham