Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push filter within joins to outer scope #920

Merged
merged 1 commit into from
Sep 24, 2017
Merged

push filter within joins to outer scope #920

merged 1 commit into from
Sep 24, 2017

Conversation

fwbrasil
Copy link
Collaborator

Fixes #919

Problem

The normalization rule that fuses on with filter is wrong.

Solution

Remove the rule and introduce new ones to avoid nested queries. They push filters to the end of the query.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@fwbrasil fwbrasil merged commit e716688 into master Sep 24, 2017
@fwbrasil fwbrasil deleted the fix-919 branch September 24, 2017 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant