Do not return annotations merged into an explicit parent in AttributeAnnotationFactory #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AnnotationFactory
|
I am currently looking into these issues too, but more from a 'how do I track all nested annotations' POV. |
|
Thanks @GuilhemN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking for a solution to fix nelmio/NelmioApiDocBundle#1993 (explanation of root issue in #1220 (comment)), and I couldn't find an easy one from NelmioApiDocBundle without duplicating a lot of code and making things more likely to break later.
I believe the best solution would be to not return annotations that are already merged in
AttributeAnnotationFactoryso that these may not be merged again later.This should have no repercussion on zircote/swagger-php internals as attributes returned by
AttributeAnnotationFactoryare passed toAnalysis::addAnnotationswhich visits recursively passed annotations and so is able to find merged attributes from their newly defined parents.What do you think? Would that be an acceptable fix for you?