Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: authorization #269

Merged
merged 20 commits into from
Dec 6, 2023
Merged

feat: authorization #269

merged 20 commits into from
Dec 6, 2023

Conversation

livio-a
Copy link
Member

@livio-a livio-a commented Dec 4, 2023 •
edited
Loading

Starts the new version of the ZITADEL SDK, which will provide more flexibility and better UX by (re)implementing the authorization feature.

relates to zitadel/zitadel#5192

BREAKING CHANGES:

NewClient functions require context.Context
remove deprecated WithKeyPath client connection option

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date (additionally docs: update go authorization example to the new version zitadel#7015)
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@livio-a
feat: authorization check for http APIs with example
7c25b95
@livio-a
feat: authorization check for grpc with example
163ec63
@livio-a
remove unused
0462e0c
@livio-a
improve http example
1a11044
@livio-a
cleanup
66d00ea
@livio-a
comments
3a5e259
@livio-a
adapt grpc example to http example and lots of comments
824cdc0
@livio-a
version v3
98916ad 
BREAKING CHANGES:

- remove pkg/api/middleware packages (Introspection middleware)
- remove deprecated `WithKeyPath` client connection option
@livio-a
update oidc and jose
c9d9229 
BREAKING CHANGES:

NewClient functions require context.Context
remove deprecated `WithKeyPath` client connection option
@livio-a livio-a changed the base branch from main to next December 4, 2023 08:09
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (next@676cc92). Click here to learn what that means.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next     #269   +/-   ##
=======================================
  Coverage        ?   34.28%           
=======================================
  Files           ?        5           
  Lines           ?      105           
  Branches        ?        0           
=======================================
  Hits            ?       36           
  Misses          ?       66           
  Partials        ?        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@livio-a livio-a mentioned this pull request Dec 5, 2023
Merged
13 tasks
@livio-a livio-a marked this pull request as ready for review December 5, 2023 07:50
muhlemmer
muhlemmer reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@muhlemmer muhlemmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ran the http example locally and it runs smooth and clear :).

2 small comments.

pkg/authorization/error.go
return true
}
return errors.Is(e.err, t.err)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoudn't we also implement the Unwrap method so the underlying error can be retreived?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutely... added it

go.mod Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are updating all the deps, perhaps we should also update the generator versions in the Dockerfile:

zitadel-go/build/zitadel/Dockerfile

Lines 18 to 23 in 745cff2

FROM ${BUILDARCH}-base AS base
ARG PROTOC_VERSION=3.18.0
ARG PROTOC_ZIP=protoc-${PROTOC_VERSION}-linux-${PROTOC_ARCH}.zip
ARG GATEWAY_VERSION=2.18.0
ARG VALIDATOR_VERSION=0.9.1
ARG TAG_NAME=main

zitadel-go/build/zitadel/Dockerfile

Lines 56 to 57 in 745cff2

RUN go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@v1.1.0
RUN go install google.golang.org/protobuf/cmd/protoc-gen-go@v1.27.1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to latest versions

@livio-a livio-a enabled auto-merge (squash) December 6, 2023 06:14
@livio-a livio-a merged commit f9a4a21 into next Dec 6, 2023
5 checks passed
@livio-a livio-a deleted the authorization branch December 6, 2023 09:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

🎉 This PR is included in version 2.2.0-next.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 2.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhlemmer muhlemmer muhlemmer approved these changes

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@livio-a @muhlemmer