Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: API client #280

Merged
merged 35 commits into from
Dec 20, 2023
Merged

feat: API client #280

merged 35 commits into from
Dec 20, 2023

Conversation

livio-a
Copy link
Member

@livio-a livio-a commented Dec 20, 2023

Adds the ability to use the ZITADEL API on a single client / connection.

relates to zitadel/zitadel#5192

To be able to initialize the SDK with more than a single ability (authN, authZ, API client) at once, the idea of providing options to the Zitadel provider had to be discarded. It would have taken to much effort to handle all cases of generic types.
The current idea is to provide a general configuration of Zitadel to the different parts, so that e.g. the authZ package can build the necessary issuer from the domain and the client can use it to connect to the API.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date (docs: update go api client guide zitadel#7099 updates as soon as this is merged)
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

# Conflicts:
#	example/api/http/main.go
#	example/app/app.go
#	pkg/authentication/authenticate.go
#	pkg/authentication/oidc/authenticate.go
#	pkg/zitadel/zitadel.go
@livio-a livio-a marked this pull request as ready for review December 20, 2023 05:46
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (f9a4a21) 34.28% compared to head (0868ad9) 34.25%.
Report is 1 commits behind head on next.

Files Patch % Lines
pkg/authorization/oauth/authorizer.go 0.00% 7 Missing ⚠️
pkg/authorization/oauth/context.go 0.00% 2 Missing ⚠️
pkg/authorization/check.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #280      +/-   ##
==========================================
- Coverage   34.28%   34.25%   -0.03%     
==========================================
  Files           5        5              
  Lines         105      108       +3     
==========================================
+ Hits           36       37       +1     
- Misses         66       68       +2     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stebenz stebenz self-requested a review December 20, 2023 14:22
@livio-a livio-a merged commit aad6fea into next Dec 20, 2023
3 of 5 checks passed
@livio-a livio-a deleted the client branch December 20, 2023 15:27
Copy link
Contributor

🎉 This PR is included in version 2.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants