Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authentication): Add Authenticator config options for session store and session cookie name. #353

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

helpisdev
Copy link
Contributor

Description

As documented in the InMemorySessions source (emphasis mine):

InMemorySessions implements the [Sessions] interface by storing the sessions
in-memory. This is obviously not suitable for production and only meant for testing purposes.

the default implementation for the session sotre is not suitable for production, thus an alternative session store implementation must be used by the end user. Currently there isn't any option to bring your own session store, so I added this option. I also added an option to change the default cookie name for completeness sake.

I don't know how you run your testing suite so I haven't added any tests yet.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@hifabienne hifabienne requested a review from livio-a July 8, 2024 09:34
@livio-a livio-a enabled auto-merge (squash) July 11, 2024 05:57
@livio-a livio-a merged commit 7515c7f into zitadel:next Jul 11, 2024
3 checks passed
@livio-a
Copy link
Member

livio-a commented Jul 11, 2024

@helpisdev thanks for this addition. This definitely makes sense.

If you like to get a gift from us, please write an email to hi@zitadel.com

Copy link
Contributor

🎉 This PR is included in version 2.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants