Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timestamps before 1980 #11

Closed
andrewkslv opened this issue Mar 3, 2018 · 2 comments
Closed

timestamps before 1980 #11

andrewkslv opened this issue Mar 3, 2018 · 2 comments

Comments

@andrewkslv
Copy link

andrewkslv commented Mar 3, 2018

ZIP does not support timestamps before 1980. It's the case of plenty issues. For instance, it's already happened here mishoo/UglifyJS#2054

$ ll ./node_modules/ssri

total 96
-rw-r--r--  1 watashi  staff   7.4K Jan  1  1970 CHANGELOG.md
-rw-r--r--  1 watashi  staff   755B Jan  1  1970 LICENSE.md
-rw-r--r--  1 watashi  staff    18K Jan  1  1970 README.md
-rw-r--r--  1 watashi  staff    10K Jan  1  1970 index.js
-rw-r--r--  1 watashi  staff   1.4K Jan  1  1970 package.json
@luke-robertson
Copy link

luke-robertson commented Mar 6, 2018

Same issue here
screen shot 2018-03-06 at 15 36 42

I think this needs ugilify updating

@zkat
Copy link
Owner

zkat commented Apr 9, 2018

This is not an issue with ssri. And npm's next release is setting the tarball dates to a post-1980 date so you can still get reproducible builds.

Seeing as it's not an ssri issue, I'm closing this.

@zkat zkat closed this as completed Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants