Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove + from all email addresses before handling #64

Open
Bisht13 opened this issue Feb 24, 2024 · 1 comment · May be fixed by #101
Open

Remove + from all email addresses before handling #64

Bisht13 opened this issue Feb 24, 2024 · 1 comment · May be fixed by #101
Labels
bug Something isn't working easy

Comments

@Bisht13
Copy link
Member

Bisht13 commented Feb 24, 2024

The relayer should remove all + concatenations in an email address such as abc+123@xyz.com should be cleaned to be abc@xyz.com before processing the mail.
@Bisht13 Bisht13 changed the title Remove + from all emails when handling Remove + from all email addresses before handling Feb 24, 2024
@Divide-By-0 Divide-By-0 added bug Something isn't working easy labels May 18, 2024
@Divide-By-0
Copy link
Member

Divide-By-0 commented Aug 4, 2024 •
edited by linear bot
Loading

If it's possible to send an email from x+y@gmail.com, I don't think we should do this. Someone should try adding that as a sender address and see if it passes. If not, then we should definitely do this -- but maybe it's better to do on emailwallet.org?

whoisgautxm added a commit to whoisgautxm/email-wallet that referenced this issue Aug 7, 2024
@whoisgautxm
feat: Remove '+' from all email addresses before handling
8e2cb09 
This change addresses issue zkemail#64 by cleaning email addresses to remove any '+' characters from the local part. This ensures proper handling of email addresses in the application.
@whoisgautxm whoisgautxm linked a pull request Aug 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Remove '+' from all email addresses before handling zkemail/email-wallet
2 participants
@Divide-By-0 @Bisht13