Allow re-minting for same twitter account if using a new reset password email #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@numtel is attempting to deploy a commit to the eeshau's projects Team on Vercel. A member of the Team first needs to authorize it. |
numtel
commented
Oct 14, 2024
| @@ -9,8 +9,6 @@ import "../src/Verifier.sol"; | |||
| contract TwitterUtilsTest is Test { | |||
| using StringUtils for *; | |||
|
|
|||
| address constant VM_ADDR = 0x7109709ECfa91a80626fF3989D68f67F5b1DD12D; // Hardcoded address of the VM from foundry | |||
There was a problem hiding this comment.
I wasn't sure what this line was adding?
There was a problem hiding this comment.
My guess is that it was some hotfix for an old foundry verrsion that required this for tests to pass. If removing this still lets tests pass, then that seems fine to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34
Both proofs can be generated from the same
.emlor different.emls with the same usernameIt doesn't hash the username like the issue description says because that's already public?
Adds the status to the svg output: