Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ashlang spartan proving #244

Merged
merged 19 commits into from
Oct 24, 2024
Merged

feat: ashlang spartan proving #244

merged 19 commits into from
Oct 24, 2024

Conversation

chancehudson
Copy link
Collaborator

@chancehudson chancehudson commented Oct 15, 2024

This PR is partially blocked by microsoft/Spartan#75. This pr uses a fork of spartan that is more friendly to proof serialization. As a result it cannot use a crates.io version of ashlang (git dependencies are not allowed in public packages).

done: generate params for ar1cs dynamically and compare to provided proof

Copy link

cloudflare-workers-and-pages bot commented Oct 15, 2024

Deploying mopro with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5e20e78
Status: ✅  Deploy successful!
Preview URL: https://4d2722ac.mopro.pages.dev
Branch Preview URL: https://ashlang-spartan-support.mopro.pages.dev

View logs

@chancehudson
Copy link
Collaborator Author

this doesn't add android tests because i don't have JNA stuff installed on my current computer. I also have not run this code on device

Copy link
Collaborator

@vivianjeng vivianjeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if each circuit only depends on ar1cs, we don't need the macro to setup circuits.
we can just replace prove with generate_ashlang_spartan_proof?

and it works well for my iPhone 👍🏻

mopro-ffi/Cargo.toml Outdated Show resolved Hide resolved
mopro-ffi/Cargo.toml Outdated Show resolved Hide resolved
mopro-ffi/src/ashlang/mod.rs Outdated Show resolved Hide resolved
mopro-ffi/src/ashlang/mod.rs Outdated Show resolved Hide resolved
mopro-ffi/src/ashlang/mod.rs Show resolved Hide resolved
@vivianjeng
Copy link
Collaborator

@chancehudson can you also include CI tests? Thank you

@vivianjeng
Copy link
Collaborator

add tests here: #246

@chancehudson
Copy link
Collaborator Author

I think if each circuit only depends on ar1cs, we don't need the macro to setup circuits.
we can just replace prove with generate_ashlang_spartan_proof?

No, uniffi needs the app to define the functions which is what the macro does. Without it app developers will need to write a function with the correct name themselves.

@vivianjeng vivianjeng merged commit e6ee5c9 into main Oct 24, 2024
23 checks passed
@vivianjeng vivianjeng deleted the ashlang-spartan-support branch October 24, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants