Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question in checkModule of compat.js #1344

Closed
biin opened this issue May 28, 2024 · 4 comments
Closed

Question in checkModule of compat.js #1344

biin opened this issue May 28, 2024 · 4 comments

Comments

@biin
Copy link

biin commented May 28, 2024

In core-js-compat, the version list is retrieved via browserslist in targets-parser.js. For iOS version 15.7.2, browserslist returns the minimum version as 16. Subsequently, the minimum version is set to 16, and the necessary polyfill list is retrieved through checkModule in compat.js.
The problem here is that for cases like es.array.to-sorted, where the minimum version is 16, checkModule uses < for comparison, so the necessary polyfills are not included. Should this be considered an error in browserslist, or is there a need for a separate handling for this version?
Thank you!

@zloirock
Copy link
Owner

zloirock commented May 28, 2024

Sorry, I don't understand what do you mean. Everything here works as expected and es.array.to-sorted marked as required for iOS 15.7.2:

image

What do you mean by "the version list is retrieved via browserslist"? Could you show your browserslist query and provide other info?

@biin
Copy link
Author

biin commented May 28, 2024

@zloirock
This issue can be reproduced by setting the browserslist query to ios >= 15.7.2.
I have confirmed that when executed as shown in the sample, there is no issue.
It seems that this issue arises from a difference in the browserslist query.

Thank you.

@biin biin closed this as completed May 28, 2024
@zloirock
Copy link
Owner

Clear, I see it:

image

In this case, it's not a core-js issue that works as expected as I have shown above, it's a browserslist issue that ios >= 15.7.2 query also should include 15.6-15.8. You could ask it in their repo.

@zloirock
Copy link
Owner

zloirock commented Aug 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants