zgrab/zgrab2: HTTP bodies getting mangled #258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DetermineEncoding
To try and translate http bodies to UTF8 if possible.How to Test
And hopefully get that a result. The chinese is the title of qq's webpage and is malformed in current results. https://censys.io/domain/qq.com
Notes & Caveats
I've tested this with some of domains from the alexa top million, but I've been unable to run a full 1% scan from
scratch-01
DetermineEncoding
returns a certainty boolean, but at least with qq it was getting the right result even though it was returning a certainty of false, so I decided to ignore itIssue Tracking