Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter is broken due to a broken dependency on an old Golang version #900

Merged
merged 13 commits into from
Nov 17, 2024
Merged
13 changes: 5 additions & 8 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,13 @@ jobs:

- name: Check out code
uses: actions/checkout@v2

- name: Set up Go
uses: actions/setup-go@v2
with:
go-version: ^1.20
- name: Install golangci-lint
run: |
wget https://github.com/golangci/golangci-lint/releases/download/v1.61.0/golangci-lint-1.61.0-linux-amd64.deb
sudo apt install -y ./golangci-lint-1.61.0-linux-amd64.deb
VERSION=1.62.0
wget https://github.com/golangci/golangci-lint/releases/download/v${VERSION}/golangci-lint-${VERSION}-linux-amd64.tar.gz
tar zxvf golangci-lint-${VERSION}-linux-amd64.tar.gz
mv golangci-lint-${VERSION}-linux-amd64/golangci-lint .
- name: Run golangci-lint
run: |
cd v3
golangci-lint run
../golangci-lint run
2 changes: 2 additions & 0 deletions v3/lint/registration.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ import (
//
// Only one of NameFilter or IncludeNames/ExcludeNames can be provided at
// a time.
//
//nolint:recvcheck
type FilterOptions struct {
// NameFilter is a regexp used to filter lints by their name. It is mutually
// exclusive with IncludeNames and ExcludeNames.
Expand Down
2 changes: 1 addition & 1 deletion v3/lint/result.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (

// LintStatus is an enum returned by lints inside of a LintResult.
//
//nolint:revive
//nolint:revive,recvcheck
type LintStatus int

// Known LintStatus values
Expand Down
2 changes: 2 additions & 0 deletions v3/lint/source.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ func (s *LintSource) FromString(src string) {
}

// SourceList is a slice of LintSources that can be sorted.
//
//nolint:recvcheck
type SourceList []LintSource

// Len returns the length of the list.
Expand Down
Loading