cancel local notification on android

[aminerol]

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-push-notification@8.0.0 for the project I'm working on.

due to deprecation of cancelLocalNotifications in favor of cancelLocalNotification, the function in component/index.android.js needs to be renamed as well to cancelLocalNotification

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-push-notification/component/index.android.js b/node_modules/react-native-push-notification/component/index.android.js
index 3496c04..0a609cb 100644
--- a/node_modules/react-native-push-notification/component/index.android.js
+++ b/node_modules/react-native-push-notification/component/index.android.js
@@ -36,8 +36,8 @@ NotificationsComponent.prototype.unsubscribeFromTopic = function(topic) {
 	RNPushNotification.unsubscribeFromTopic(topic);
 };
 
-NotificationsComponent.prototype.cancelLocalNotifications = function(details) {
-	RNPushNotification.cancelLocalNotifications(details);
+NotificationsComponent.prototype.cancelLocalNotification = function(details) {
+	RNPushNotification.cancelLocalNotification(details);
 };
 
 NotificationsComponent.prototype.clearLocalNotification = function(details, tag) {

This issue body was partially generated by patch-package.

[dimadeveatii]

I can confirm this is a valid issue.
On Android, cancelLocalNotification method doesn't work.

@Dallas62 can we get a hotfix released soon? We're using this library in production and this issue prevents us from making a release.

[Dallas62]

cancelLocalNotification(s) are working the same way, expect for the warning.
The fix provided is the same as suggested, just removed extra steps.
If you have issues, please describe the problem with steps.

For the unsubscribeTopic, the fix will come later, the warning is not blocking.

[dimadeveatii]

@Dallas62 thanks for a quick reaction.

When calling PushNotification.cancelLocalNotification method it gets to this line:

react-native-push-notification/index.js

Line 498 in 17ad0ae

return this.callNative('cancelLocalNotification', [notificationId]);

Now, in component/index.android.js there is no such method as cancelLocalNotification, only cancelLocalNotifications. As a result, this line gets executed, and nothing happens:

react-native-push-notification/index.js

Line 38 in 17ad0ae

return null;

Fix:
There should be defined method cancelLocalNotification in component/index.android.js file.

[dimadeveatii]

Cancelling local notifications in android is completely broken in v8.0.0, regardless that you call the deprecated cancelLocalNotifications or the new cancelLocalNotification methods.

[Dallas62]

Please provide a PR if you have the fix. I don’t have time to spend on it this week.

[dimadeveatii]

Thanks @Dallas62 !
When would we be able to see it released on npm?

[Dallas62]

Tonight if the PR is ready.

[dimadeveatii]

The PR changes are very straightforward, please see it here: https://github.com/zo0r/react-native-push-notification/pull/2125/files

[Dallas62]

Just release the patch.
Thanks for this catch & PR!