Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors on joinSession() are not correctly logged #3

Closed
bojcicm opened this issue Oct 18, 2024 · 2 comments
Closed

Errors on joinSession() are not correctly logged #3

bojcicm opened this issue Oct 18, 2024 · 2 comments

Comments

@bojcicm
Copy link

bojcicm commented Oct 18, 2024

If error occurs after line

yield e.joinSession()

In catch block it doesnt handle error correctly.
On UI it will display message UIKit: [Object object]
No logs in console, couldn't figure out what was wrong.

In minified file I had to update catch logic after joinSession()
Instead of

catch(i) {
  e.error.throw("UIKit", i);
  e.isLoading = false;
}

I have changed it to

catch(i) {
  e.error.throw("UIKit", i.reason);
  console.error(i);
  e.isLoading = false;
}
@bojcicm bojcicm closed this as completed Oct 18, 2024
@bojcicm
Copy link
Author

bojcicm commented Oct 18, 2024

@tommygaessler
Copy link
Member

Thank you for the feedback @bojcicm , we will work on this and update you in the main repo as you linked to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@tommygaessler @bojcicm and others