Design Question: Unify horizontal padding for every page #5598
goplayoutside3
started this conversation in
Ideas
Replies: 4 comments
-
Beta Was this translation helpful? Give feedback.
0 replies
-
Thanks for bringing this to our attention. I couldn't find any supporting documentation on previous margin and padding decisions, so I'll take this opportunity to unify everything. Desktop sizing:
Mobile sizing:
|
Beta Was this translation helpful? Give feedback.
0 replies
-
This is super helpful! Noting a couple things here that apply to near-future dev work:
|
Beta Was this translation helpful? Give feedback.
0 replies
-
Completed by: #5813 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
How to unify horizontal alignment via padding in each page layout?
Motivation
This is a design-focused discussion. While developing and reviewing the newly designed About Zooniverse Pages, @seanmiller26 and I are focusing on mobile-responsive design, too. I think it’d be helpful to define a consistent horizontal padding for all FEM pages, for both desktop-width and mobile-width designs.
For example, on a
/projects
Classify page there are four sections: ZooHeader, ProjectHeader, main, and ZooFooter.On a desktop browser, the horizontal padding is:
- ZooHeader: 30px
- ProjectHeader: 30px
- main: 20px
- ZooFooter: 50px
On a mobile browser, the horizontal padding is:
- ZooHeader: 30px padding left, 15px padding right (asymmetrical)
- ProjectHeader: 20px
- main: 15px
- ZooFooter: 25px
Because of the inconsistency as you scroll down the page, the left and right edge of content is not aligned. This also makes it difficult to build new pages like the About Zooniverse pages which have an AboutHeader component and main content sandwiched between the ZooHeader and ZooFooter.
Here's an example of the padding mentioned marked by red arrows:
Describe the solution you'd like
It would be helpful during development of new FEM pages to have a clearly defined horizontal padding for the general FEM layout. This includes the sections mentioned above: header, main, and footer. Once defined, we can better utilize the Grommet theme padding definitions.
I also think it's fine if an element on the edge of the screen is intentionally designed to be not aligned with elements above and below it. At this point though, I don't think there's a unified definition of horizontal padding for FEM as a whole.
Please feel free to expand this discussion to include vertical padding of headers, main, footer, and the vertical padding in between elements on a page, too.
Beta Was this translation helpful? Give feedback.
All reactions