-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project: client-side page data requests (/_next/data/ URLs) broken #1826
Comments
I think the problem might be related to the page data requests going to a 404 page in PFE. |
Sentry issue: FEM-APP-PROJECT-CZ |
The problem goes away if you browse the NextJS app directly on your phone: The problem seems to be with proxying requests to |
OOI do we know why this isn't an issue on other browsers? |
In other browsers, the page is refreshed from the server after the client-side fetch fails. See https://github.com/zooniverse/operations/issues/497#issuecomment-699907536 |
Fixed on staging by adding a routing rule to forward Note that this prevents us from using client-side routing for the About pages, since they would also request data from |
Let's see how this works on staging before deciding how we'd like to fix it in production. |
If Next 9.5 allows us to run multiple Next apps on the same domain, then #1886 may fix this by allowing us to run |
I'm looking at this in production now, for the HMS NHS beta. Requests are being made for the workflow and subject set JSON, as expected eg. Our nginx setup redirects those to |
This has been fixed in production by proxying data requests to It can be reopened if we find we need to proxy requests for both NextJS apps. |
Package
app-project
Describe the bug
Client-side workflow routing is broken in mobile Safari.
EDIT: the underlying cause of this bug is that Next's data request URLs are broken, because they aren't being proxied through to a NextJS app. eg. https://www.zooniverse.org/_next/data/cy3jPk61vsMFAGo-Zi51-/projects/msalmon/hms-nhs-the-nautical-health-service/classify/workflow/16926/subject-set/82738.json
To Reproduce
Loading a workflow page directly will work eg.
https://frontend.preview.zooniverse.org/projects/darkeshard/engaging-the-crowds-2020/classify/workflow/16099
Expected behavior
The workflow page should load with that workflow shown in the classifier.
The text was updated successfully, but these errors were encountered: