Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project home page: workflow loading broken in Safari. #1827

Closed
eatyourgreens opened this issue Sep 28, 2020 · 1 comment · Fixed by #1809
Closed

Project home page: workflow loading broken in Safari. #1827

eatyourgreens opened this issue Sep 28, 2020 · 1 comment · Fixed by #1809
Labels
bug Something isn't working

Comments

@eatyourgreens
Copy link
Contributor

Package
app-project

Describe the bug
The workflow selector in the project Hero component shows: 'There was an error fetching the workflows :('

To Reproduce
Load any project home page that has active workflows eg. https://frontend.preview.zooniverse.org/projects/cseidenstuecker/every-name-counts

Safari 12.1 on macOS 10.14

The culprit is Promise.allSettled here, which isn't supported in Safari 12. It should fallback to Promise.all instead of failing.

const subjectSets = linked ? linked.subject_sets : []
await Promise.allSettled(subjectSets.map(fetchPreviewImage))
return { subjectSets, workflows }

@eatyourgreens eatyourgreens added the bug Something isn't working label Sep 28, 2020
@eatyourgreens eatyourgreens changed the title Project hoe page: workflow loading broken in Safari. Project home page: workflow loading broken in Safari. Sep 28, 2020
@eatyourgreens
Copy link
Contributor Author

Fixed in #1809 by moving the promises to Node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant