Workflow selection modal showing on PH TESS

[mrniaboc]

The workflow selection modal that was built as part of the Engaging Crowds Indexing Tool effort is now showing on Planet Hunters TESS. It was originally designed to only show on projects with more than one live workflow, and should not be showing on PH TESS as it adds an unnecessary extra step for the volunteers to get through when they navigate to the classify tab.

See https://zooniverse.slack.com/archives/CANKLB50E/p1645782976011779

[eatyourgreens]

We used to set a default workflowID in the Classify page props, but I think I removed that, somewhere along the line. Probably a mistake, to be honest.

front-end-monorepo/packages/app-project/src/helpers/getStaticPageProps/getStaticPageProps.js

Lines 26 to 30 in 745e946

	const { workflowID } = params
	const { project } = getSnapshot(store)
	const language = project.primary_language
	const { active_workflows, default_workflow } = project.links
	const workflowOrder = project.configuration?.workflow_order || []

[eatyourgreens]

I removed the default workflow in #2580. I think that was an accident.

EDIT: Declaring a default, with URL params taking precedence, might fix this issue:

const workflowID = params.workflowID || store.project.defaultWorkflow

[mcbouslog]

I removed the default workflow in #2580. I think that was an accident.

EDIT: Declaring a default, with URL params taking precedence, might fix this issue:

const workflowID = params.workflowID || store.project.defaultWorkflow

I think removing reference to a default workflow was ok, is in line with ADR 34.

Shortly I'll open a PR that sets the workflow ID to the only workflow if there's only one active workflow. I think that solves the issue and is consistent with our intent to remove default workflow? Completely open to suggestion though, I don't have a staunch opinion.

Noting TESS' only active workflow isn't set as it's default workflow.

[eatyourgreens]

project.defaultWorkflow returns a project’s single active workflow.

front-end-monorepo/packages/app-project/stores/Project.js

Line 47 in 745e946

return singleActiveWorkflow

[eatyourgreens]

Sorry, that was the wrong link but this should save you some work.

front-end-monorepo/packages/app-project/stores/Project.js

Lines 41 to 48 in 745e946

	get defaultWorkflow() {
	const activeWorkflows = self.links['active_workflows']
	let singleActiveWorkflow
	if (activeWorkflows.length === 1) {
	[singleActiveWorkflow] = self.links['active_workflows']
	}
	return singleActiveWorkflow
	},