Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client-side application error on refresh with drawing mark #3251

Closed
mcbouslog opened this issue Jun 2, 2022 · 5 comments · Fixed by #3293
Closed

Client-side application error on refresh with drawing mark #3251

mcbouslog opened this issue Jun 2, 2022 · 5 comments · Fixed by #3293
Labels
bug Something isn't working degraded-ux UX is degraded

Comments

@mcbouslog
Copy link
Contributor

Package

  • lib-classifier?

Describe the bug

Create a transcription line with subtask text, refresh the page (will prompt "Reload?", click "Reload"), then client-side application error.
To clear error must clear browser session storage.

Bug - https://www.zooniverse.org/projects/humphrydavy/davy-notebooks-project?demo=true
Similar project without bug - https://www.zooniverse.org/projects/rachaelsking/corresponding-with-quakers?demo=true

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://www.zooniverse.org/projects/humphrydavy/davy-notebooks-project/classify/workflow/21240?demo=true
  2. Create line, in subtask add text, click "Save and Close"
  3. Refresh page (will be prompted "Reload?", click "Reload")
  4. See error

Expected behavior

Do same steps as noted above on https://www.zooniverse.org/projects/rachaelsking/corresponding-with-quakers/classify/workflow/20713?demo=true - no error

@mcbouslog mcbouslog added bug Something isn't working degraded-ux UX is degraded labels Jun 2, 2022
@mcbouslog
Copy link
Contributor Author

Please change this issue title once we have a better idea of it's cause.

@mcbouslog
Copy link
Contributor Author

Noting Davy Notebooks has prioritized: true vs Corresponding with Quakers prioritized: false

@mcbouslog
Copy link
Contributor Author

I think I've isolated the issue to https://github.com/zooniverse/front-end-monorepo/blob/master/packages/lib-classifier/src/components/Classifier/ClassifierContainer.js#L77 -

const classifierStore = useHydratedStore(storeEnvironment, cachePanoptesData, `fem-classifier-${project.id}`)

@mcbouslog
Copy link
Contributor Author

Introduced in #2863 (checked commit before confirmed no error, commit of PR confirmed error).

@eatyourgreens
Copy link
Contributor

eatyourgreens commented Jun 10, 2022

This is fixed by #3293, which adds error handling to the useHydratedStore hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working degraded-ux UX is degraded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants