Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace im_func with __func__ #57

Closed
ale-rt opened this issue Dec 10, 2018 · 4 comments
Closed

Replace im_func with __func__ #57

ale-rt opened this issue Dec 10, 2018 · 4 comments
Assignees
Labels

Comments

@ale-rt
Copy link
Member

ale-rt commented Dec 10, 2018

Here:

@ale-rt
Copy link
Member Author

ale-rt commented Dec 10, 2018

I am unsure if doing a PR to fix this.
Apparently get_dispatcher is not used anywhere.
Can we just deprecate replace im_func with func and deprecate that method?

@dataflake
Copy link
Member

@icemac assigned me here but I am not familiar with that code, I just forward-ported all that from a different branch back then. That function has no test coverage, either.

@ale-rt just go ahead and do it, including the deprecation warning. If there's problems people need to speak up, then we'll know.

@ale-rt
Copy link
Member Author

ale-rt commented Feb 9, 2019

Thanks! I just forgot this one

@dataflake
Copy link
Member

@ale-rt I just couldn't stand seeing it on the list anymore 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants